Merged
Conversation
Rejects F/481
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses several protocol-level correctness issues in the wolfIP stack, spanning DNS response handling, TCP ACK processing, and ICMP socket binding behavior.
Changes:
- DNS client: validate response XID before parsing, and fix returned A-record IP byte order.
- TCP: process ACKs while in
TCP_CLOSE_WAIT. - ICMP: persist
bound_local_ipon bind; add clarification comment on RTT tick wrap behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/wolfip.c |
Implements DNS XID validation + A-record IP byte order fix; processes TCP ACK in CLOSE_WAIT; stores bound_local_ip for ICMP binds; adds RTT wrap clarification comment. |
src/test/unit/unit.c |
Updates/extends unit tests for DNS byte order + wrong-XID ignore behavior, ICMP bind behavior, and TCP CLOSE_WAIT ACK processing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
philljj
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F/477: fix byteorder in DNS returned IP address
F/478: Bind ICMP sockets to an IP address / interface
F/479: Fix ACK processing in CLOSE_WAIT state
F/480: DNS client: properly validate XID before accepting record
F/481: Add comment to clarify RTT wrapping logic.